Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-10-02 07:26:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

rpcrt4: Fix memory leak in NdrFullPointerXlatFree. <rob at codeweavers.com>

Browse source 
First of all, the code was freeing the wrong pointer (i.e. the pointer
supplied by the caller of one of the NdrFullPointer* functions, not the
PFULL_PTR_TO_REFID_ELEMENT. Second, the code wasn't following the Next
link to the next entry in the list.

svn path=/trunk/; revision=31852
This commit is contained in:
Christoph von Wittich 2008-01-18 10:37:37 +00:00
parent bf565b3d3a
commit 02f7a25753
1 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
reactos/dll/win32/rpcrt4/ndr_fullpointer.c
View file

@ -68,8 +68,17 @@ void WINAPI NdrFullPointerXlatFree(PFULL_PTR_XLAT_TABLES pXlatTables)
TRACE("(%p)\n", pXlatTables);
/* free the entries in the table */
for (i = 0; i < pXlatTables->RefIdToPointer.NumberOfEntries; i++)
HeapFree(GetProcessHeap(), 0, pXlatTables->RefIdToPointer.XlatTable[i]);
for (i = 0; i < pXlatTables->PointerToRefId.NumberOfBuckets; i++)
{
PFULL_PTR_TO_REFID_ELEMENT XlatTableEntry;
for (XlatTableEntry = pXlatTables->PointerToRefId.XlatTable[i];
XlatTableEntry; )
{
PFULL_PTR_TO_REFID_ELEMENT Next = XlatTableEntry->Next;
HeapFree(GetProcessHeap(), 0, XlatTableEntry);
XlatTableEntry = Next;
}
}
HeapFree(GetProcessHeap(), 0, pXlatTables->RefIdToPointer.XlatTable);
HeapFree(GetProcessHeap(), 0, pXlatTables->RefIdToPointer.StateTable);