Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-12-31 19:42:51 +00:00
Code Issues Projects Releases Packages Wiki Activity

[UMPNPMGR] GenerateDeviceID must fail, if pszDeviceID contains backslashes

Browse source
This commit is contained in:
Eric Kohl 2022-04-19 23:14:23 +02:00
parent 291a94cd6f
commit 0296fce00e
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
base/services/umpnpmgr/rpcserver.c
View file

@ -3004,11 +3004,20 @@ GenerateDeviceID(
_In_ PNP_RPC_STRING_LEN ulLength) _In_ PNP_RPC_STRING_LEN ulLength)
{ {
WCHAR szGeneratedInstance[MAX_DEVICE_ID_LEN]; WCHAR szGeneratedInstance[MAX_DEVICE_ID_LEN];
PWCHAR ptr;
HKEY hKey; HKEY hKey;
DWORD dwInstanceNumber; DWORD dwInstanceNumber;
DWORD dwError = ERROR_SUCCESS; DWORD dwError = ERROR_SUCCESS;
CONFIGRET ret = CR_SUCCESS; CONFIGRET ret = CR_SUCCESS;
/* Fail, if the device name contains backslashes */
ptr = pszDeviceID;
while (*ptr != UNICODE_NULL)
{
if (*ptr == L'\\')
return CR_INVALID_DEVICE_ID;
}
/* Generated ID is: Root\<Device ID>\<Instance number> */ /* Generated ID is: Root\<Device ID>\<Instance number> */
dwInstanceNumber = 0; dwInstanceNumber = 0;
while (dwError == ERROR_SUCCESS) while (dwError == ERROR_SUCCESS)