Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-04-05 21:21:33 +00:00
Code Issues Projects Releases Packages Wiki Activity

[SHELL32] Improve file properties dialog (#5852)

Browse source 
Based on KRosUser's patches.
- Add missing version strings "Comments" and
  "LegalTrademarks".
- Add version strings "PrivateBuild" and
  "SpecialBuild" if necessary.
- Trim the version string for pretty display.
CORE-19270, CORE-19114, CORE-19275
This commit is contained in:
Katayama Hirofumi MZ 2023-10-30 15:34:03 +09:00 committed by GitHub
parent 87f94aa10c
commit 00f192fa94
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
dll/win32/shell32/dialogs/filedefext.cpp
View file

@ -852,6 +852,14 @@ CFileDefExt::InitVersionPage(HWND hwndDlg)
AddVersionString(hwndDlg, L"OriginalFilename"); AddVersionString(hwndDlg, L"OriginalFilename");
AddVersionString(hwndDlg, L"FileVersion"); AddVersionString(hwndDlg, L"FileVersion");
AddVersionString(hwndDlg, L"ProductVersion"); AddVersionString(hwndDlg, L"ProductVersion");
AddVersionString(hwndDlg, L"Comments");
AddVersionString(hwndDlg, L"LegalTrademarks");
if (pInfo && (pInfo->dwFileFlags & VS_FF_PRIVATEBUILD))
AddVersionString(hwndDlg, L"PrivateBuild");
if (pInfo && (pInfo->dwFileFlags & VS_FF_SPECIALBUILD))
AddVersionString(hwndDlg, L"SpecialBuild");
/* Attach file version to dialog window */ /* Attach file version to dialog window */
SetWindowLongPtr(hwndDlg, DWLP_USER, (LONG_PTR)this); SetWindowLongPtr(hwndDlg, DWLP_USER, (LONG_PTR)this);
@ -957,8 +965,11 @@ CFileDefExt::VersionPageProc(HWND hwndDlg, UINT uMsg, WPARAM wParam, LPARAM lPar
if (pwszData == NULL) if (pwszData == NULL)
break; break;
TRACE("hDlgCtrl %x string %s\n", hDlgCtrl, debugstr_w(pwszData)); CString str(pwszData);
SetDlgItemTextW(hwndDlg, 14010, pwszData); str.Trim();
TRACE("hDlgCtrl %x string %s\n", hDlgCtrl, debugstr_w(str));
SetDlgItemTextW(hwndDlg, 14010, str);
return TRUE; return TRUE;
} }