Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-02-22 08:25:03 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ACGENRAL] Don't leak memory on failure in InitIgnoreFreeLibrary()

Browse source 
CID 1441306
This commit is contained in:
Pierre Schweitzer 2018-11-16 22:02:46 +01:00
parent 52da844825
commit 007cc5cd8a
No known key found for this signature in database
GPG key ID: 7545556C3D585B0B
1 changed files with 14 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
dll/appcompat/shims/genral/ignorefreelib.c
View file

@ -97,7 +97,7 @@ static VOID InitIgnoreFreeLibrary(PCSTR CommandLine)
if (!names[n]) if (!names[n])
{ {
SHIM_WARN("Unable to allocate %u bytes\n", cur - prev + 2); SHIM_WARN("Unable to allocate %u bytes\n", cur - prev + 2);
return; goto fail;
} }
n++; n++;
prev = cur + 1; prev = cur + 1;
@ -106,11 +106,23 @@ static VOID InitIgnoreFreeLibrary(PCSTR CommandLine)
if (!names[n]) if (!names[n])
{ {
SHIM_WARN("Unable to allocate last string\n"); SHIM_WARN("Unable to allocate last string\n");
return; goto fail;
} }
g_Names = names; g_Names = names;
g_NameCount = count; g_NameCount = count;
return;
fail:
--n;
while (n >= 0)
{
if (names[n])
ShimLib_ShimFree((PVOID)names[n]);
--n;
}
ShimLib_ShimFree(names);
} }
BOOL WINAPI SHIM_OBJ_NAME(Notify)(DWORD fdwReason, PVOID ptr) BOOL WINAPI SHIM_OBJ_NAME(Notify)(DWORD fdwReason, PVOID ptr)