Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-12-31 19:42:51 +00:00
Code Issues Projects Releases Packages Wiki Activity
reactos/base/shell/explorer/settings.cpp

99 lines
4.1 KiB
C++
Raw Normal View History

[EXPLORER_NEW] - Correctly load and save advanced setting(s). Patch by Edijs Kolesnikovičs. CORE-6835 #resolve svn path=/trunk/; revision=58122
2013-01-06 10:08:10 +00:00
/*
* ReactOS Explorer
*
* Copyright 2013 - Edijs Kolesnikovics
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 2.1 of the License, or (at your option) any later version.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public
* License along with this library; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
*/
* Slap *some* sense into our header inclusions. * This significantly shrinks the dependency tracking data and the compiled objects size, which speeds up the whole build process (especially the incremental builds) accelerating the daily development as a result. * No intended code changes, ~27% smaller build. Enjoy ;) svn path=/trunk/; revision=58214
2013-01-24 23:00:42 +00:00
#include "precomp.h"
[EXPLORER_NEW] - Correctly load and save advanced setting(s). Patch by Edijs Kolesnikovičs. CORE-6835 #resolve svn path=/trunk/; revision=58122
2013-01-06 10:08:10 +00:00
[EXPLORER] -Rewrite taskbar settings routines and dialog - Rewrite the taskbar settings and start menu settings property sheets. - All settings in the taskbar settings property sheet can be loaded and saved properly except for the quick launch one which will be implemented later. - Implement toggling lock, autohide and always on top. The rest will be implemented later.
2017-10-30 15:39:12 +00:00
TaskbarSettings g_TaskbarSettings;
[EXPLORER_NEW] - Correctly load and save advanced setting(s). Patch by Edijs Kolesnikovičs. CORE-6835 #resolve svn path=/trunk/; revision=58122
2013-01-06 10:08:10 +00:00
[EXPLORER] -Rewrite taskbar settings routines and dialog - Rewrite the taskbar settings and start menu settings property sheets. - All settings in the taskbar settings property sheet can be loaded and saved properly except for the quick launch one which will be implemented later. - Implement toggling lock, autohide and always on top. The rest will be implemented later.
2017-10-30 15:39:12 +00:00
BOOL TaskbarSettings::Save()
[EXPLORER_NEW] - Correctly load and save advanced setting(s). Patch by Edijs Kolesnikovičs. CORE-6835 #resolve svn path=/trunk/; revision=58122
2013-01-06 10:08:10 +00:00
{
[EXPLORER] -Rewrite taskbar settings routines and dialog - Rewrite the taskbar settings and start menu settings property sheets. - All settings in the taskbar settings property sheet can be loaded and saved properly except for the quick launch one which will be implemented later. - Implement toggling lock, autohide and always on top. The rest will be implemented later.
2017-10-30 15:39:12 +00:00
SHSetValueW(hkExplorer, NULL, L"EnableAutotray", REG_DWORD, &bHideInactiveIcons, sizeof(bHideInactiveIcons));
[EXPLORER] Show time and date when two lines are available in the taskbar clock area (#5410) - Add registry key to show the time and date when two lines are available in the taskbar clock area. - Keep old behavior when `PreferDateOverWeekday` registry key in `HKCU\Software\Microsoft\Windows\CurrentVersion\Explorer\Advanced` is set to 0 or not present. When three or more lines are available, the clock will continue to show the time, day of the week, and the date. When only one line is visible, the clock will continue to only display the time. CORE-19018
2023-07-08 22:04:45 +00:00
SHSetValueW(hkExplorer, L"Advanced", L"PreferDateOverWeekday", REG_DWORD, &bPreferDate, sizeof(bPreferDate));
[EXPLORER] -Rewrite taskbar settings routines and dialog - Rewrite the taskbar settings and start menu settings property sheets. - All settings in the taskbar settings property sheet can be loaded and saved properly except for the quick launch one which will be implemented later. - Implement toggling lock, autohide and always on top. The rest will be implemented later.
2017-10-30 15:39:12 +00:00
SHSetValueW(hkExplorer, L"Advanced", L"ShowSeconds", REG_DWORD, &bShowSeconds, sizeof(bShowSeconds));
SHSetValueW(hkExplorer, L"Advanced", L"TaskbarGlomming", REG_DWORD, &bGroupButtons, sizeof(bGroupButtons));
BOOL bAllowSizeMove = !bLock;
SHSetValueW(hkExplorer, L"Advanced", L"TaskbarSizeMove", REG_DWORD, &bAllowSizeMove, sizeof(bAllowSizeMove));
sr.cbSize = sizeof(sr);
[EXPLORER] Large taskbar icon support (#5465) - Use HKCU\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\Advanced\TaskbarSmallIcons registry key to store the icon size setting for the taskbar. - If the registry value is missing, small icons will be used by default. - If the registry value is set to 1, it will also use small icons. - Only if the value exists and is set to 0 it will use large icons. This allows us to use the same registry value as Windows 7 explorer, while also keeping the taskbar icons small in most cases, especially running the shell on unmodified Windows Server 2003. CORE-11698
2023-07-22 15:24:28 +00:00
SHSetValueW(hkExplorer, L"Advanced", L"TaskbarSmallIcons", REG_DWORD, &bSmallIcons, sizeof(bSmallIcons));
[EXPLORER] Set icon size and show or hide desktop button from taskbar properties (#5510) CORE-11698, CORE-15369 Allows a user to set the icon size and show or hide the desktop button in the taskbar using the taskbar properties menu. After applying these changes, the taskbar updates and resizes without requiring a restart. - This PR moves the 'Notification Area' section into its own separate tab. This allows us to include more options for users without increasing the size of the window. It is also very similar to the Windows Vista taskbar properties menu. - Some minor changes to allow the taskbar to refresh its view when the icon size or show desktop button setting changes.
2023-08-10 15:06:55 +00:00
SHSetValueW(hkExplorer, L"Advanced", L"TaskbarSd", REG_DWORD, &bShowDesktopButton, sizeof(bShowDesktopButton));
[EXPLORER] -Rewrite taskbar settings routines and dialog - Rewrite the taskbar settings and start menu settings property sheets. - All settings in the taskbar settings property sheet can be loaded and saved properly except for the quick launch one which will be implemented later. - Implement toggling lock, autohide and always on top. The rest will be implemented later.
2017-10-30 15:39:12 +00:00
SHSetValueW(hkExplorer, L"StuckRects2", L"Settings", REG_BINARY, &sr, sizeof(sr));
[EXPLORER_NEW] - Correctly load and save advanced setting(s). Patch by Edijs Kolesnikovičs. CORE-6835 #resolve svn path=/trunk/; revision=58122
2013-01-06 10:08:10 +00:00
[EXPLORER] -Rewrite taskbar settings routines and dialog - Rewrite the taskbar settings and start menu settings property sheets. - All settings in the taskbar settings property sheet can be loaded and saved properly except for the quick launch one which will be implemented later. - Implement toggling lock, autohide and always on top. The rest will be implemented later.
2017-10-30 15:39:12 +00:00
/* TODO: AutoHide writes something to HKEY_CURRENT_USER\Software\Microsoft\Internet Explorer\Desktop\Components\0 figure out what and why */
return TRUE;
[EXPLORER_NEW] - Correctly load and save advanced setting(s). Patch by Edijs Kolesnikovičs. CORE-6835 #resolve svn path=/trunk/; revision=58122
2013-01-06 10:08:10 +00:00
}
[EXPLORER] -Rewrite taskbar settings routines and dialog - Rewrite the taskbar settings and start menu settings property sheets. - All settings in the taskbar settings property sheet can be loaded and saved properly except for the quick launch one which will be implemented later. - Implement toggling lock, autohide and always on top. The rest will be implemented later.
2017-10-30 15:39:12 +00:00
BOOL TaskbarSettings::Load()
[EXPLORER] start reworking some code for loading/saving settings implementation CORE-11498 - Rename the settings structure to something more meaningful for using it for all taskbar related settings - define some default settings - check checkboxes with settings values in the properties window - move saving the settings to an own function which will be implemented later svn path=/trunk/; revision=74307
2017-04-14 18:08:34 +00:00
{
[EXPLORER] -Rewrite taskbar settings routines and dialog - Rewrite the taskbar settings and start menu settings property sheets. - All settings in the taskbar settings property sheet can be loaded and saved properly except for the quick launch one which will be implemented later. - Implement toggling lock, autohide and always on top. The rest will be implemented later.
2017-10-30 15:39:12 +00:00
DWORD dwRet, cbSize, dwValue = NULL;
[EXPLORER] - Load and save "Lock Taskbar", "Hide inactive icons", and "Group similar taskbar buttons". Verified on Win2k3 via "Nirsoft RegFromApp". - use a loader function for registry values. - save the "show seconds" setting together with the other explorer settings instead of a ROS specific key. - Add some documentation comments. svn path=/trunk/; revision=74500
2017-05-08 15:27:33 +00:00
[EXPLORER] -Rewrite taskbar settings routines and dialog - Rewrite the taskbar settings and start menu settings property sheets. - All settings in the taskbar settings property sheet can be loaded and saved properly except for the quick launch one which will be implemented later. - Implement toggling lock, autohide and always on top. The rest will be implemented later.
2017-10-30 15:39:12 +00:00
cbSize = sizeof(dwValue);
dwRet = SHGetValueW(hkExplorer, L"Advanced", L"TaskbarSizeMove", NULL, &dwValue, &cbSize);
bLock = (dwRet == ERROR_SUCCESS) ? (dwValue == 0) : TRUE;
[FORMATTING] Remove trailing whitespace. Addendum to 34593d93. Excluded: 3rd-party code (incl. wine) and most of the win32ss.
2021-09-13 01:33:14 +00:00
[EXPLORER] Show time and date when two lines are available in the taskbar clock area (#5410) - Add registry key to show the time and date when two lines are available in the taskbar clock area. - Keep old behavior when `PreferDateOverWeekday` registry key in `HKCU\Software\Microsoft\Windows\CurrentVersion\Explorer\Advanced` is set to 0 or not present. When three or more lines are available, the clock will continue to show the time, day of the week, and the date. When only one line is visible, the clock will continue to only display the time. CORE-19018
2023-07-08 22:04:45 +00:00
dwRet = SHGetValueW(hkExplorer, L"Advanced", L"PreferDateOverWeekday", NULL, &dwValue, &cbSize);
bPreferDate = (dwRet == ERROR_SUCCESS) ? (dwValue != 0) : FALSE; /* This is opt-in setting */
[EXPLORER] -Rewrite taskbar settings routines and dialog - Rewrite the taskbar settings and start menu settings property sheets. - All settings in the taskbar settings property sheet can be loaded and saved properly except for the quick launch one which will be implemented later. - Implement toggling lock, autohide and always on top. The rest will be implemented later.
2017-10-30 15:39:12 +00:00
dwRet = SHGetValueW(hkExplorer, L"Advanced", L"ShowSeconds", NULL, &dwValue, &cbSize);
bShowSeconds = (dwRet == ERROR_SUCCESS) ? (dwValue != 0) : FALSE;
[EXPLORER] - Load and save "Lock Taskbar", "Hide inactive icons", and "Group similar taskbar buttons". Verified on Win2k3 via "Nirsoft RegFromApp". - use a loader function for registry values. - save the "show seconds" setting together with the other explorer settings instead of a ROS specific key. - Add some documentation comments. svn path=/trunk/; revision=74500
2017-05-08 15:27:33 +00:00
[EXPLORER] -Rewrite taskbar settings routines and dialog - Rewrite the taskbar settings and start menu settings property sheets. - All settings in the taskbar settings property sheet can be loaded and saved properly except for the quick launch one which will be implemented later. - Implement toggling lock, autohide and always on top. The rest will be implemented later.
2017-10-30 15:39:12 +00:00
dwRet = SHGetValueW(hkExplorer, L"Advanced", L"TaskbarGlomming", NULL, &dwValue, &cbSize);
bGroupButtons = (dwRet == ERROR_SUCCESS) ? (dwValue != 0) : FALSE;
[EXPLORER] start reworking some code for loading/saving settings implementation CORE-11498 - Rename the settings structure to something more meaningful for using it for all taskbar related settings - define some default settings - check checkboxes with settings values in the properties window - move saving the settings to an own function which will be implemented later svn path=/trunk/; revision=74307
2017-04-14 18:08:34 +00:00
[EXPLORER] -Rewrite taskbar settings routines and dialog - Rewrite the taskbar settings and start menu settings property sheets. - All settings in the taskbar settings property sheet can be loaded and saved properly except for the quick launch one which will be implemented later. - Implement toggling lock, autohide and always on top. The rest will be implemented later.
2017-10-30 15:39:12 +00:00
dwRet = SHGetValueW(hkExplorer, NULL, L"EnableAutotray", NULL, &dwValue, &cbSize);
bHideInactiveIcons = (dwRet == ERROR_SUCCESS) ? (dwValue != 0) : FALSE;
[EXPLORER_NEW] - Correctly load and save advanced setting(s). Patch by Edijs Kolesnikovičs. CORE-6835 #resolve svn path=/trunk/; revision=58122
2013-01-06 10:08:10 +00:00
[EXPLORER] Large taskbar icon support (#5465) - Use HKCU\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\Advanced\TaskbarSmallIcons registry key to store the icon size setting for the taskbar. - If the registry value is missing, small icons will be used by default. - If the registry value is set to 1, it will also use small icons. - Only if the value exists and is set to 0 it will use large icons. This allows us to use the same registry value as Windows 7 explorer, while also keeping the taskbar icons small in most cases, especially running the shell on unmodified Windows Server 2003. CORE-11698
2023-07-22 15:24:28 +00:00
dwRet = SHGetValueW(hkExplorer, L"Advanced", L"TaskbarSmallIcons", NULL, &dwValue, &cbSize);
bSmallIcons = (dwRet == ERROR_SUCCESS) ? (dwValue != 0) : TRUE;
[EXPLORER] Add support for Windows 7 style system tray icon spacing (#5489) When using large taskbar icon: - Increase the padding around system tray icons. - Push the clock text further to the right, increasing the left padding between the clock and notification icons. This matches Windows 7 shell behavior. - Correct the spacing for the clock area, in the case when bPreferDate is enabled, only two lines are visible, and the day of the week is shorter than the date. CORE-11698
2023-08-04 11:20:19 +00:00
dwRet = SHGetValueW(hkExplorer, L"Advanced", L"CompactTrayIcons", NULL, &dwValue, &cbSize);
[EXPLORER] Notification area icon improvements (#6169) Automatically adjusts the spacing of the tray icons according to the small or large taskbar icons setting. Also, a minor bug fix to the clock spacing when switching between taskbar icon sizes. CORE-19380 Update the ROS-specific CompactTrayIcons registry value from a binary yes/no to have three states. The three states are as follows: 0 (default) - Automatic. When small taskbar icons are used, the notification area will use compact tray icon spacing. When large taskbar icons are used, the notification area will use larger tray icon spacing. While no version of Windows behaves this way, I believe this is a smart default choice for ReactOS since users wanting large taskbar icons will generally expect larger tray icon spacing, while users with small taskbar icons may want more compact spacing. 1 - Never Compact. Regardless of the taskbar icon size setting, the notification area will always use the larger spacing. This follows the behavior of Windows 7 and newer versions. 2 - Always Compact. Regardless of the taskbar icon size setting, the notification area will always use the compact spacing. This follows the behavior of Windows Vista and older versions. Fix a clock spacing bug that occurs when changing the taskbar size before advancing to the next minute. The taskbar clock now adjusts its spacing when the size of the taskbar changes.
2023-12-23 20:21:12 +00:00
if (dwRet == ERROR_SUCCESS && dwValue <= TIM_Max)
eCompactTrayIcons = static_cast<TrayIconsMode>(dwValue);
else
eCompactTrayIcons = TIM_Default;
[EXPLORER] Add support for Windows 7 style system tray icon spacing (#5489) When using large taskbar icon: - Increase the padding around system tray icons. - Push the clock text further to the right, increasing the left padding between the clock and notification icons. This matches Windows 7 shell behavior. - Correct the spacing for the clock area, in the case when bPreferDate is enabled, only two lines are visible, and the day of the week is shorter than the date. CORE-11698
2023-08-04 11:20:19 +00:00
[EXPLORER] Set icon size and show or hide desktop button from taskbar properties (#5510) CORE-11698, CORE-15369 Allows a user to set the icon size and show or hide the desktop button in the taskbar using the taskbar properties menu. After applying these changes, the taskbar updates and resizes without requiring a restart. - This PR moves the 'Notification Area' section into its own separate tab. This allows us to include more options for users without increasing the size of the window. It is also very similar to the Windows Vista taskbar properties menu. - Some minor changes to allow the taskbar to refresh its view when the icon size or show desktop button setting changes.
2023-08-10 15:06:55 +00:00
dwRet = SHGetValueW(hkExplorer, L"Advanced", L"TaskbarSd", NULL, &dwValue, &cbSize);
bShowDesktopButton = (dwRet == ERROR_SUCCESS) ? (dwValue != 0) : TRUE;
[EXPLORER] -Rewrite taskbar settings routines and dialog - Rewrite the taskbar settings and start menu settings property sheets. - All settings in the taskbar settings property sheet can be loaded and saved properly except for the quick launch one which will be implemented later. - Implement toggling lock, autohide and always on top. The rest will be implemented later.
2017-10-30 15:39:12 +00:00
cbSize = sizeof(sr);
dwRet = SHGetValueW(hkExplorer, L"StuckRects2", L"Settings", NULL, &sr, &cbSize);
[EXPLORER_NEW] - Correctly load and save advanced setting(s). Patch by Edijs Kolesnikovičs. CORE-6835 #resolve svn path=/trunk/; revision=58122
2013-01-06 10:08:10 +00:00
[EXPLORER] -Rewrite taskbar settings routines and dialog - Rewrite the taskbar settings and start menu settings property sheets. - All settings in the taskbar settings property sheet can be loaded and saved properly except for the quick launch one which will be implemented later. - Implement toggling lock, autohide and always on top. The rest will be implemented later.
2017-10-30 15:39:12 +00:00
/* Make sure we have correct values here */
if (dwRet != ERROR_SUCCESS || sr.cbSize != sizeof(sr) || cbSize != sizeof(sr))
{
sr.Position = ABE_BOTTOM;
sr.AutoHide = FALSE;
sr.AlwaysOnTop = TRUE;
[EXPLORER] Start menu: Fix Small Icons flag (#6651) Follow-up to #6646. Fix wrong flag use: #6646 (comment) JIRA issue: CORE-19494 - Delete SmallStartMenu flag (wrong) from _TW_STUCKRECTS2. - Rename _TW_STUCKRECTS2.SmallIcons as SmSmallIcons. - Use SmSmallIcons flag.
2024-03-22 12:15:22 +00:00
sr.SmSmallIcons = FALSE;
[EXPLORER] -Rewrite taskbar settings routines and dialog - Rewrite the taskbar settings and start menu settings property sheets. - All settings in the taskbar settings property sheet can be loaded and saved properly except for the quick launch one which will be implemented later. - Implement toggling lock, autohide and always on top. The rest will be implemented later.
2017-10-30 15:39:12 +00:00
sr.HideClock = FALSE;
sr.Rect.left = sr.Rect.top = 0;
sr.Rect.bottom = sr.Rect.right = 1;
sr.Size.cx = sr.Size.cy = 0;
}
else
{
if (sr.Position > ABE_BOTTOM)
sr.Position = ABE_BOTTOM;
[EXPLORER_NEW] - Correctly load and save advanced setting(s). Patch by Edijs Kolesnikovičs. CORE-6835 #resolve svn path=/trunk/; revision=58122
2013-01-06 10:08:10 +00:00
}
[EXPLORER] -Rewrite taskbar settings routines and dialog - Rewrite the taskbar settings and start menu settings property sheets. - All settings in the taskbar settings property sheet can be loaded and saved properly except for the quick launch one which will be implemented later. - Implement toggling lock, autohide and always on top. The rest will be implemented later.
2017-10-30 15:39:12 +00:00
return TRUE;
[EXPLORER_NEW] - Correctly load and save advanced setting(s). Patch by Edijs Kolesnikovičs. CORE-6835 #resolve svn path=/trunk/; revision=58122
2013-01-06 10:08:10 +00:00
}
/* EOF */
Reference in a new issue Copy permalink